fix(ContextMenuCommandBuilder): allow emoji in name #10790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10790 +/- ##
=======================================
Coverage 39.12% 39.12%
=======================================
Files 244 244
Lines 14798 14798
Branches 1412 1412
=======================================
Hits 5790 5790
Misses 8996 8996
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jiralite
approved these changes
Mar 4, 2025
vladfrangu
approved these changes
Mar 4, 2025
Qjuh
requested changes
Mar 4, 2025
packages/builders/src/interactions/commands/contextMenu/Assertions.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Qjuh <76154676+Qjuh@users.noreply.github.com>
Qjuh
approved these changes
Mar 5, 2025
github-project-automation
bot
moved this from Review in Progress
to Review Approved
in discord.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Closes #10789